apoorvmittal10 commented on code in PR #20144:
URL: https://github.com/apache/kafka/pull/20144#discussion_r2200612707
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -717,7 +718,7 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
ByteBuffer compressedPayload;
try {
compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
- } catch (Throwable e) {
+ } catch (IOException | NoClassDefFoundError e) {
log.debug("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
Review Comment:
I don't think there is any value in having a separete PR and we can't
achieve the right way in this PR itself, we should create a jira and fix it.
Else there is something else for which you need this change to go early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
