TaiJuWu commented on code in PR #20061:
URL: https://github.com/apache/kafka/pull/20061#discussion_r2204389166
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/InternalTopicManager.java:
##########
@@ -50,16 +49,16 @@ public class InternalTopicManager {
* Configures the internal topics for the given topology. Given a topology
and the topics image, this method determines the number of
* partitions for all internal topics and returns a {@link
ConfiguredTopology} object.
*
- * @param logContext The log context.
- * @param metadataHash The metadata hash of the group.
- * @param topology The topology.
- * @param topicsImage The topics image.
+ * @param logContext The log context.
+ * @param metadataHash The metadata hash of the group.
+ * @param topology The topology.
+ * @param metadataImage The topics image.
Review Comment:
How about `the coordinator metadata image contain topics`?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/EndpointToPartitionsManager.java:
##########
@@ -38,7 +38,7 @@ private EndpointToPartitionsManager() {
public static StreamsGroupHeartbeatResponseData.EndpointToPartitions
endpointToPartitions(final StreamsGroupMember streamsGroupMember,
final StreamsGroupHeartbeatResponseData.Endpoint
responseEndpoint,
final StreamsGroup streamsGroup,
-
final MetadataImage metadataImage) {
+
final CoordinatorMetadataImage metadataImage) {
Review Comment:
Have you considered renaming this parameter to coordinatorMetadataImage to
avoid confusion with original `metadataImage`?
##########
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorMetadataImage.java:
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.coordinator.common.runtime;
+
+import org.apache.kafka.common.Uuid;
+
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+
+/**
+ * Provides metadata to Coordinators (GroupCoordinator, ShareCoordinator, etc)
such as topics, partitions, and their configurations.
+ * Implementations should be thread-safe and immutable.
+ */
+public interface CoordinatorMetadataImage {
+ static CoordinatorMetadataImage EMPTY = emptyImage();
Review Comment:
static is redunant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
