zzbennett commented on code in PR #20061:
URL: https://github.com/apache/kafka/pull/20061#discussion_r2200053645
##########
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java:
##########
@@ -2474,37 +2472,37 @@ public void scheduleUnloadOperation(
* @param delta The metadata delta.
*/
public void onNewMetadataImage(
- MetadataImage newImage,
- MetadataDelta delta
+ CoordinatorMetadataImage newImage,
+ CoordinatorMetadataDelta delta
) {
throwIfNotRunning();
- log.debug("Scheduling applying of a new metadata image with offset
{}.", newImage.offset());
+ log.debug("Scheduling applying of a new metadata image with offset
{}.", newImage.version());
// Update global image.
metadataImage = newImage;
// Push an event for each coordinator.
coordinators.keySet().forEach(tp -> {
- scheduleInternalOperation("UpdateImage(tp=" + tp + ", offset=" +
newImage.offset() + ")", tp, () -> {
+ scheduleInternalOperation("UpdateImage(tp=" + tp + ", offset=" +
newImage.version() + ")", tp, () -> {
Review Comment:
I will update `offset=` to `version=` here, and update the log statements in
this method. I also found a few comments in
`GroupMetadataManager.onNewMetadataImage` that reference "offset" instead of
"version" so I will update those as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
