JimmyWang6 commented on code in PR #20144:
URL: https://github.com/apache/kafka/pull/20144#discussion_r2213234395
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -713,14 +716,20 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
return Optional.empty();
}
- CompressionType compressionType =
ClientTelemetryUtils.preferredCompressionType(localSubscription.acceptedCompressionTypes());
+ CompressionType compressionType =
ClientTelemetryUtils.preferredCompressionType(localSubscription.acceptedCompressionTypes(),
unsupportedCompressionTypes);
ByteBuffer compressedPayload;
try {
compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
- } catch (Throwable e) {
- log.debug("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
- compressedPayload = ByteBuffer.wrap(payload.toByteArray());
- compressionType = CompressionType.NONE;
+ } catch (Throwable e) {
+ if (e instanceof IOException || e instanceof
NoClassDefFoundError ||
+ e.getCause() instanceof NoClassDefFoundError) {
+ log.debug("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
Review Comment:
I think maybe we could change the log level to error, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
