frankvicky commented on code in PR #20200: URL: https://github.com/apache/kafka/pull/20200#discussion_r2217208569
########## metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java: ########## @@ -1230,6 +1230,40 @@ public void testEligibleLeaderReplicas_ElectLastKnownLeaderShouldFail() { builder.setTargetIsr(List.of()); + // No change to the partition. + assertEquals(Optional.empty(), builder.build()); + } + + @Test Review Comment: This leads to style checks failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org