frankvicky commented on code in PR #20200:
URL: https://github.com/apache/kafka/pull/20200#discussion_r2217519557
##########
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##########
@@ -1233,4 +1233,72 @@ public void
testEligibleLeaderReplicas_ElectLastKnownLeaderShouldFail() {
// No change to the partition.
assertEquals(Optional.empty(), builder.build());
}
+
+ @Test
Review Comment:
```suggestion
@EnumSource(value = Election.class, names = {"PREFERRED", "UNCLEAN"})
@ParameterizedTest
public void
testEligibleLeaderReplicas_NotEligibleLastKnownLeader(Election election) {
```
Please also change `.setElection(Election.PREFERRED)` to
`.setElection(election)`
In this way, we don't need another similar test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
