TaiJuWu commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2227774442
##########
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##########
@@ -1054,7 +1054,7 @@ private List<TopicPartition>
filterNonExistentPartitions(Collection<TopicPartiti
.map(partitionInfo -> new
TopicPartition(entry.getKey(), partitionInfo.partition())))
.toList();
- return topicPartitions.stream().filter(element ->
!existPartitions.contains(element)).toList();
+ return topicPartitions.stream().filter(tp ->
!existPartitions.contains(tp)).toList();
Review Comment:
Sorry, I didn’t quite get your point. 'tp' is a change I made, and it’s
already widely used throughout our codebase.
I also happy to revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
