Yunyung commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2228324106


##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##########
@@ -153,6 +154,26 @@ public void 
testResetOffsetsNotExistingGroup(ClusterInstance cluster) throws Exc
         }
     }
 
+    @ClusterTest(brokers = 5)
+    public void testResetOffsetsWithOfflinePartition(ClusterInstance cluster) 
throws Exception {

Review Comment:
   To better distinguish this test from 
`testResetOffsetsWithPartitionNoneLeader`, maybe rename it to 
`testResetOffsetsWithOfflinePartitionNotInResetTarget` or something similar.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to