kevin-wu24 commented on code in PR #20422:
URL: https://github.com/apache/kafka/pull/20422#discussion_r2310747296


##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -842,6 +846,7 @@ public void handleException(Throwable exception) {
 
         @Override
         public void complete(Throwable exception) {
+            controllerMetrics.updateIdleEndTime();

Review Comment:
   > We measure controller idleness in two main scenarios
   
   Can you add this section in the PR description instead of linking to the KIP?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to