MahsaSeifikar commented on code in PR #20422:
URL: https://github.com/apache/kafka/pull/20422#discussion_r2319986360
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -549,6 +550,7 @@ private Throwable handleEventException(
} else {
deltaUs = OptionalLong.empty();
}
+ controllerMetrics.updateIdleStartTime();
Review Comment:
If we call `updateIdleStartTime` inside `updateEventQueueProcessingTime`,
this creates an issue in `handleEventException` because if
`startProcessingTimeNs` is not present, we skip calling
`updateEventQueueProcessingTime`. As a result, the idle timer never gets
started.
Regardless of whether the processing time is updated, we always need to
start the idle timer, so the functions should be decoupled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
