shashankhs11 commented on code in PR #20544:
URL: https://github.com/apache/kafka/pull/20544#discussion_r2353916527
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -2280,39 +2282,34 @@ public void suspend() {
}
@Test
- public void shouldCommitNonCorruptedTasksOnTaskCorruptedException() {
- final ProcessorStateManager stateManager =
mock(ProcessorStateManager.class);
-
- final StateMachineTask corruptedTask = new StateMachineTask(taskId00,
taskId00Partitions, true, stateManager);
- final StateMachineTask nonCorruptedTask = new
StateMachineTask(taskId01, taskId01Partitions, true, stateManager);
+ public void shouldNotCommitCorruptedTasksOnTaskCorruptedException() {
Review Comment:
I renamed this test from
`shouldCommitNonCorruptedTasksOnTaskCorruptedException`. Based on my
understanding, the commit logic happens at the `StreamThread` level, but only
the exception propagation happens in `TaskManager` with `checkStateUpdater`. So
I decided to omit the check for commit logic and rewrite the test.
And hence I propose to rename to
`shouldNotCommitCorruptedTasksOnTaskCorruptedException`
Please correct if I am wrong or If I misunderstood!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
