shashankhs11 commented on code in PR #20544:
URL: https://github.com/apache/kafka/pull/20544#discussion_r2361104941
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -261,7 +279,7 @@ public void
shouldLockAllTasksOnCorruptionWithProcessingThreads() {
.inState(State.RUNNING)
.withInputPartitions(taskId00Partitions).build();
final TasksRegistry tasks = mock(TasksRegistry.class);
- final TaskManager taskManager =
setUpTaskManager(ProcessingMode.AT_LEAST_ONCE, tasks, true, true);
+ final TaskManager taskManager =
setUpTaskManager(ProcessingMode.AT_LEAST_ONCE, tasks, true);
Review Comment:
I agree, it is definitely a bit confusing 😅
The reason I did this is because, I wanted to identify all the tests that
would fail after we removed the `stateUpdaterEnabled` flag. I thought the
safest way to rewrite these tests incrementally would be to add another
overloaded method without the flag, so we don’t break the CI checks in the
meantime. This would temporarily add in a lot of unnecessary code, but my plan
was to clean it up once all the tests are updated.
Do you think this approach make sense? I would really appreciate your
thoughts, and I’m open to any suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
