lucasbru commented on code in PR #20541:
URL: https://github.com/apache/kafka/pull/20541#discussion_r2354937516
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/IQv2IntegrationTest.java:
##########
@@ -423,10 +441,13 @@ public String metricsScope() {
);
// Discard the basic streams and replace with test-specific topology
- kafkaStreams.close();
+ if (kafkaStreams != null) {
+ kafkaStreams.close();
+ }
final String safeTestName = safeUniqueTestName(testInfo);
kafkaStreams = new KafkaStreams(builder.build(),
streamsConfiguration(safeTestName));
kafkaStreams.cleanUp();
+ this.groupProtocol = groupProtocol;
Review Comment:
Agreed, his seems incorrect. Why do we need to set it here? Why do we need
the member variable `groupProtocol` in the first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
