lucasbru commented on code in PR #20541:
URL: https://github.com/apache/kafka/pull/20541#discussion_r2354951810
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/IQv2IntegrationTest.java:
##########
@@ -86,7 +88,7 @@
import static org.hamcrest.Matchers.matchesPattern;
import static org.junit.jupiter.api.Assertions.assertThrows;
-@Timeout(600)
+@Timeout(1200)
Review Comment:
Do we actually need to bump the timeout here? Junit @Timeout annotation
apply to a single parameter combination, so we should only bump this if the new
protocol is in fact slower.
Same below
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java:
##########
@@ -103,19 +115,21 @@ public static void before() throws Exception {
producer.send(new ProducerRecord<>(INPUT_TOPIC_NAME, 0,
RECORD_TIMESTAMPS[2], RECORD_KEY, RECORD_VALUES[2])).get();
producer.send(new ProducerRecord<>(INPUT_TOPIC_NAME, 0,
RECORD_TIMESTAMPS[3], RECORD_KEY, RECORD_VALUES[3])).get();
}
- INPUT_POSITION.withComponent(INPUT_TOPIC_NAME, 0, 3);
+ inputPosition = Position.emptyPosition();
+ inputPosition = inputPosition.withComponent(INPUT_TOPIC_NAME, 0, 3);
Review Comment:
I would combine these two lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
