Nikita-Shupletsov commented on code in PR #20570:
URL: https://github.com/apache/kafka/pull/20570#discussion_r2380421092
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java:
##########
@@ -251,8 +251,6 @@ public void initializeStartupTasks(final TopologyMetadata
topologyMetadata,
);
try {
- task.initializeIfNeeded();
Review Comment:
I converted the PR to a draft for now.
I pushed a change and would like to get some feedback:
I extracted the metric creation to a separate method as it was recommended,
but there is a metric that's published during
init(https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java#L131-L135).
I am not 100% sure what to do with it.
also, should the method check the state or something of the task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
