mjsax commented on code in PR #20570:
URL: https://github.com/apache/kafka/pull/20570#discussion_r2380548034
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStore.java:
##########
@@ -276,6 +272,19 @@ public void init(final StateStoreContext
stateStoreContext, final StateStore roo
);
}
+ @Override
+ public void initMetricsIfNeeded() {
+ registerMetrics();
+ }
+
+ private void registerMetrics() {
Review Comment:
Why are we adding this? Seems, we can just put the code of this method
directly into `initMetricsIfNeeded` ?
Seems this also applies to other classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
