mjsax commented on code in PR #20661:
URL: https://github.com/apache/kafka/pull/20661#discussion_r2414857210
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -524,17 +525,41 @@ public void handleResponse(PushTelemetryResponse
response) {
lock.writeLock().unlock();
}
}
+
+ private boolean isRetryable(final KafkaException maybeFatalException) {
+ if (maybeFatalException == null) {
+ return true;
+ }
+
+ Throwable cause;
+ if (maybeFatalException.getClass() == KafkaException.class) {
+ if (maybeFatalException.getCause() == null) {
+ return false;
Review Comment:
Also, if we have a `KafkaException`, (which is not `instanceof Retriable`,
should we treat it as fatal right away? Is the case of `KafkaException` with a
`RetriableException` a case, that is really retriable (does this case even
exist?) -- Should the top level exception not be an `instanceof
RetriableException` to begin with?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
