chia7712 commented on code in PR #20661:
URL: https://github.com/apache/kafka/pull/20661#discussion_r2433576874
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -528,13 +529,13 @@ public void handleResponse(PushTelemetryResponse
response) {
@Override
public void
handleFailedGetTelemetrySubscriptionsRequest(KafkaException
maybeFatalException) {
log.debug("The broker generated an error for the get telemetry
network API request", maybeFatalException);
- handleFailedRequest(maybeFatalException != null);
+ handleFailedRequest(isRetryable(maybeFatalException));
}
@Override
public void handleFailedPushTelemetryRequest(KafkaException
maybeFatalException) {
log.debug("The broker generated an error for the push telemetry
network API request", maybeFatalException);
- handleFailedRequest(maybeFatalException != null);
+ handleFailedRequest(isRetryable(maybeFatalException));
Review Comment:
With this change, the consumer will display the following warning, even
though users may not be concerned with telemetry
```
[2025-10-16 02:27:16,077] WARN Received unrecoverable error from broker,
disabling telemetry
(org.apache.kafka.common.telemetry.internals.ClientTelemetryReporter)
```
Perhaps we shouldn't print the warning if the error is an
`UnsupportedVersionException`. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
