TaiJuWu commented on code in PR #20318:
URL: https://github.com/apache/kafka/pull/20318#discussion_r2377049920


##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##########
@@ -633,6 +634,47 @@ public void testBeginQuorumEpochHeartbeat(boolean 
withKip853Rpc) throws Exceptio
         context.assertSentBeginQuorumEpochRequest(epoch, Set.of(remoteId1, 
remoteId2));
     }
 
+    @Test
+    public void testBeginQuorumShouldNotSendAfterFetchRequest() throws 
Exception {
+        ReplicaKey localId = replicaKey(randomReplicaId(), true);
+        int remoteId1 = localId.id() + 1;
+        int remoteId2 = localId.id() + 2;
+        ReplicaKey replicaKey1 = replicaKey(remoteId1, true);
+        ReplicaKey replicaKey2 = replicaKey(remoteId2, true);
+
+        RaftClientTestContext context = new 
RaftClientTestContext.Builder(localId.id(), localId.directoryId().get())
+                .withRaftProtocol(KIP_853_PROTOCOL)
+                .withStartingVoters(VoterSetTest.voterSet(Stream.of(localId, 
replicaKey1, replicaKey2)), KRaftVersion.KRAFT_VERSION_1)
+                .build();
+
+        context.unattachedToLeader();
+        int epoch = context.currentEpoch();
+        assertEquals(OptionalInt.of(localId.id()), context.currentLeader());
+
+        // begin epoch requests should be sent out every 
beginQuorumEpochTimeoutMs

Review Comment:
   All comments are addressed, thanks for review!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to