jsancio commented on code in PR #20318:
URL: https://github.com/apache/kafka/pull/20318#discussion_r2376663893


##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -1476,6 +1475,7 @@ private boolean hasValidClusterId(String 
requestClusterId) {
      * - {@link Errors#INVALID_REQUEST} if the request epoch is larger than 
the leader's current epoch
      *     or if either the fetch offset or the last fetched epoch is invalid
      */
+    @SuppressWarnings("CyclomaticComplexity")

Review Comment:
   Why do you need this now? You didn't change this method.
   
   If you are still getting a cyclomatic complexity warning, you can try 
changing the first 2 `if` statements to `if ... else if ...`. That may lower 
the cyclomatic complexity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to