apalan60 commented on code in PR #20699:
URL: https://github.com/apache/kafka/pull/20699#discussion_r2442424085
##########
release/release.py:
##########
@@ -245,8 +248,8 @@ def prereq(name, soft_check):
fail(f"Pre-requisite not met: {name}. Error: {e}")
prereq('Apache Maven CLI (mvn) in PATH', lambda: "Apache Maven" in
execute("mvn -v"))
prereq("svn CLI in PATH", lambda: "svn" in execute("svn --version"))
- prereq("Verifying that you have no unstaged git changes", lambda:
git.has_unstaged_changes())
- prereq("Verifying that you have no staged git changes", lambda:
git.has_staged_changes())
+ prereq("Verifying that you have no unstaged git changes", lambda: not
git.has_unstaged_changes())
Review Comment:
Thanks for the review and for helping confirm the issue.
I’ve applied the related changes, and here’s how to reproduce the problem
and verify the fix:
https://github.com/apache/kafka/pull/20699#issuecomment-3418423695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
