apalan60 commented on code in PR #20699:
URL: https://github.com/apache/kafka/pull/20699#discussion_r2449939566


##########
release/release.py:
##########
@@ -127,14 +127,17 @@ def command_stage_docs():
     if not os.path.exists(kafka_site_repo_path) or not 
os.path.exists(os.path.join(kafka_site_repo_path, "powered-by.html")):
         fail("{kafka_site_repo_path} doesn't exist or does not appear to be 
the kafka-site repository")
 
-    jdk21_env = get_jdk(21)
+    jdk25_env = get_jdk(25)

Review Comment:
   @chia7712 
   Thanks for the review.  
   I’ve made the related updates. Below is a comparison between the previous 
and updated versions:
   
   ---
   
   Before
   ```txt
   python release.py
   
   Requirements:
   1. Updated docs to reference the new release version where appropriate.
   2. JDK8 and JDK17 compilers and libraries
   3. Your Apache ID, already configured with SSH keys on id.apache.org and SSH 
keys available in this shell session
   4. All issues in the target release resolved with valid resolutions (if not, 
this script will report the problematic JIRAs)
   5. A GPG key used for signing the release. This key should have been added 
to public Apache servers and the KEYS file on the Kafka site
   ...
   
   Do you have all of these setup? (y/n): 
   ```
   
   After
   ```txt
   python release.py
   
   Requirements:
   1. Updated docs to reference the new release version where appropriate.
   2. JDK25 compiler and libraries
   3. Your Apache ID, already configured with SSH keys on id.apache.org and SSH 
keys available in this shell session
   4. All issues in the target release resolved with valid resolutions (if not, 
this script will report the problematic JIRAs)
   5. A GPG key used for signing the release. This key should have been added 
to public Apache servers and the KEYS file on the Kafka site
   ...
   
   Do you have all of these setup? (y/n): 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to