mjsax commented on code in PR #20723:
URL: https://github.com/apache/kafka/pull/20723#discussion_r2462204737
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1845,6 +1845,9 @@ public Map<String, Object>
getRestoreConsumerConfigs(final String clientId) {
baseConsumerProps.put(CommonClientConfigs.CLIENT_ID_CONFIG, clientId);
baseConsumerProps.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "none");
+ // disable auto topic creation
+ baseConsumerProps.put(ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG,
"false");
Review Comment:
Why don't we add this to `NON_CONFIGURABLE_CONSUMER_DEFAULT_CONFIGS` and
also set it centrally in `getCommonConsumerConfigs()` ?
For this case, we can also remove the corresponding line in
`getMainConsumerConfigs()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
