mjsax commented on code in PR #20723:
URL: https://github.com/apache/kafka/pull/20723#discussion_r2496567028
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1834,6 +1833,7 @@ public Map<String, Object>
getRestoreConsumerConfigs(final String clientId) {
// Get restore consumer override configs
final Map<String, Object> restoreConsumerProps =
originalsWithPrefix(RESTORE_CONSUMER_PREFIX);
+ checkIfUnexpectedUserSpecifiedConsumerConfig(restoreConsumerProps,
NON_CONFIGURABLE_CONSUMER_DEFAULT_CONFIGS);
Review Comment:
Do we need to make this call here? Isn't the check inside
`getCommonConsumerConfigs()` enough?
Side note: I just realized that we use
`checkIfUnexpectedUserSpecifiedConsumerConfig` also for the producer. Might be
good to rename to `checkIfUnexpectedUserSpecifiedClientConfig` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
