C0urante commented on code in PR #20750:
URL: https://github.com/apache/kafka/pull/20750#discussion_r2464153837


##########
connect/runtime/src/main/java/org/apache/kafka/connect/connector/policy/PrincipalConnectorClientConfigOverridePolicy.java:
##########
@@ -32,7 +32,9 @@
 /**
  * Allows all {@code sasl} configurations to be overridden via the connector 
configs by setting {@code connector.client.config.override.policy} to
  * {@code Principal}. This allows to set a principal per connector.
+ * @deprecated Use {@link AllowlistConnectorClientConfigOverridePolicy} 
instead.
  */
+@Deprecated(since = " 4.2", forRemoval = true)

Review Comment:
   Can we add a warning log message when this class is instantiated to notify 
users about its deprecation and what steps they should take to prepare for its 
removal?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to