chia7712 commented on code in PR #20750:
URL: https://github.com/apache/kafka/pull/20750#discussion_r2476201955
##########
connect/runtime/src/main/java/org/apache/kafka/connect/connector/policy/PrincipalConnectorClientConfigOverridePolicy.java:
##########
@@ -32,7 +32,9 @@
/**
* Allows all {@code sasl} configurations to be overridden via the connector
configs by setting {@code connector.client.config.override.policy} to
* {@code Principal}. This allows to set a principal per connector.
+ * @deprecated Use {@link AllowlistConnectorClientConfigOverridePolicy}
instead.
*/
+@Deprecated(since = " 4.2", forRemoval = true)
public class PrincipalConnectorClientConfigOverridePolicy extends
AbstractConnectorClientConfigOverridePolicy {
Review Comment:
```
> Task :connect:runtime:compileTestJava
/home/chia7712/project/kafka/connect/runtime/src/test/java/org/apache/kafka/connect/connector/policy/PrincipalConnectorClientConfigOverridePolicyTest.java:30:
warning: [removal] PrincipalConnectorClientConfigOverridePolicy in
org.apache.kafka.connect.connector.policy has been deprecated and marked for
removal
ConnectorClientConfigOverridePolicy
principalConnectorClientConfigOverridePolicy = new
PrincipalConnectorClientConfigOverridePolicy();
^
Note:
/home/chia7712/project/kafka/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java
uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 warning
```
@mimaison Do you have time to open a minor PR to fix the warning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
