chia7712 commented on code in PR #20799:
URL: https://github.com/apache/kafka/pull/20799#discussion_r2481455085
##########
clients/src/main/java/org/apache/kafka/common/protocol/types/Struct.java:
##########
@@ -382,79 +257,6 @@ public Struct set(String name, Object value) {
return this;
}
- public Struct set(Field.Str def, String value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.NullableStr def, String value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.Int8 def, byte value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.Int32 def, int value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.Int64 def, long value) {
Review Comment:
Could you cleanup the setters as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
