chia7712 commented on code in PR #20799:
URL: https://github.com/apache/kafka/pull/20799#discussion_r2483745203
##########
clients/src/main/java/org/apache/kafka/common/protocol/types/Struct.java:
##########
@@ -382,79 +152,6 @@ public Struct set(String name, Object value) {
return this;
}
- public Struct set(Field.Str def, String value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.NullableStr def, String value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.Int8 def, byte value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.Int32 def, int value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.Int64 def, long value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.UUID def, Uuid value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.Int16 def, short value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.Uint16 def, int value) {
- if (value < 0 || value > UNSIGNED_SHORT_MAX) {
- throw new RuntimeException("Invalid value for unsigned short for "
+
- def.name + ": " + value);
- }
- return set(def.name, value);
- }
-
- public Struct set(Field.Uint32 def, long value) {
- if (value < 0 || value > UNSIGNED_INT_MAX) {
- throw new RuntimeException("Invalid value for unsigned int for " +
- def.name + ": " + value);
- }
- return set(def.name, value);
- }
-
- public Struct set(Field.Float64 def, double value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.Bool def, boolean value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.Array def, Object[] value) {
- return set(def.name, value);
- }
-
- public Struct set(Field.ComplexArray def, Object[] value) {
- return set(def.name, value);
- }
-
- public Struct setByteArray(String name, byte[] value) {
- ByteBuffer buf = value == null ? null : ByteBuffer.wrap(value);
- return set(name, buf);
- }
-
- public Struct setIfExists(Field.Array def, Object[] value) {
- return setIfExists(def.name, value);
- }
-
- public Struct setIfExists(Field.ComplexArray def, Object[] value) {
- return setIfExists(def.name, value);
- }
-
public Struct setIfExists(Field def, Object value) {
Review Comment:
this could be removed as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
