chia7712 commented on code in PR #20638:
URL: https://github.com/apache/kafka/pull/20638#discussion_r2484875771
##########
tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java:
##########
@@ -192,6 +200,21 @@ private static Set<Path> parseLocations(ArgumentParser
parser, Namespace namespa
return pluginLocations;
}
+ private static void validatePluginPath(String pluginPath, String
configName) throws ConfigException {
+ String trimmed = pluginPath.trim();
+ if (trimmed.isEmpty()) {
+ throw new ConfigException("'" + configName + "' must not be
empty.");
+ }
+
+ String[] pluginPathElements = COMMA_WITH_WHITESPACE.split(trimmed, -1);
+
+ for (String path : pluginPathElements) {
Review Comment:
This check seems intended to handle values like `,`, which result in empty
items. IIRC, the configuration's existing validator only target empty "value".
This PR makes the check stricter than the current configuration, what do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
