adixitconfluent commented on code in PR #20810:
URL: https://github.com/apache/kafka/pull/20810#discussion_r2486248615
##########
share-coordinator/src/test/java/org/apache/kafka/coordinator/share/ShareCoordinatorServiceTest.java:
##########
@@ -872,11 +875,12 @@ public void testWriteStateWhenNotStarted() throws
ExecutionException, Interrupte
new WriteShareGroupStateRequestData.PartitionData()
.setPartition(partition2)
.setStartOffset(0)
+ .setDeliveryCompleteCount(10)
.setStateEpoch(1)
.setLeaderEpoch(1)
.setStateBatches(List.of(new
WriteShareGroupStateRequestData.StateBatch()
.setFirstOffset(0)
- .setLastOffset(10)
+ .setLastOffset(9)
Review Comment:
Ideally, we should not be changing this value for the test, rather adjust
the `deliveryCompleteCount` according to the original test. Same for other
tests in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
