adixitconfluent commented on code in PR #20810:
URL: https://github.com/apache/kafka/pull/20810#discussion_r2486387506
##########
clients/src/main/resources/common/message/WriteShareGroupStateRequest.json:
##########
@@ -37,6 +40,8 @@
"about": "The leader epoch of the share-partition." },
{ "name": "StartOffset", "type": "int64", "versions": "0+",
"about": "The share-partition start offset, or -1 if the start
offset is not being written." },
+ { "name": "DeliveryCompleteCount", "type": "int32", "versions": "1+",
"ignorable": "true", "default": "-1",
+ "about": "The number of offsets greater than or equal to
share-partition start offset for which delivery has been completed."},
Review Comment:
Following @AndrewJSchofield's comment, nit: space between " } please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
