kevin-wu24 commented on code in PR #20707:
URL: https://github.com/apache/kafka/pull/20707#discussion_r2487618324
##########
core/src/main/scala/kafka/server/KafkaRaftServer.scala:
##########
@@ -181,9 +181,9 @@ object KafkaRaftServer {
}
// Load the BootstrapMetadata.
- val bootstrapDirectory = new BootstrapDirectory(config.metadataLogDir)
- val bootstrapMetadata = bootstrapDirectory.read()
- (metaPropsEnsemble, bootstrapMetadata)
+ // val bootstrapDirectory = new BootstrapDirectory(config.metadataLogDir)
+ // val bootstrapMetadata = bootstrapDirectory.read()
+ (metaPropsEnsemble, null)
Review Comment:
~~To make this change more compatible for the existing test framework, we
should instead pass down a BootstrapCheckpointFactory/Builder or something like
that. Then have two separate implementations:~~
~~One for tests that specifies a BootstrapMetadata object all in-memory
based on the factory.
In the actual implementation, we can point that factory to the actual files
on disk we would be reading.~~
~~Either way, in QuorumController#handleLoadSnapshot, that is when we
actually "resolve" this bootstrap metadata stuff by calling a method on the
factory/builder object.~~\
EDIT: after looking at `QuorumTestHarness` and `KafkaClusterTestKit`, we
shouldn't need to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
