kevin-wu24 commented on code in PR #20707:
URL: https://github.com/apache/kafka/pull/20707#discussion_r2487787098
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1022,7 +1021,22 @@ public void
handleLoadSnapshot(SnapshotReader<ApiMessageAndVersion> reader) {
Batch<ApiMessageAndVersion> batch = reader.next();
long offset = batch.lastOffset();
List<ApiMessageAndVersion> messages = batch.records();
-
+ if (bootstrapMetadata == null) {
+ if
(reader.snapshotId().equals(Snapshots.BOOTSTRAP_SNAPSHOT_ID)) {
+ // For bootstrap snapshots, extract feature
levels from all data records
+ if (batch.controlRecords().isEmpty()) {
+ System.out.println("DEBUG: Extracting
bootstrap metadata from " + messages.size() + " records");
+ bootstrapMetadata =
BootstrapMetadata.fromRecords(messages, "bootstrap");
+ System.out.println("DEBUG: Bootstrap
metadata extracted: " + bootstrapMetadata);
+ }
+ } else {
+ Map<String, Short> featureVersions = new
HashMap<>();
+ MetadataVersion metadataVersion =
MetadataVersion.latestProduction();
+
featureVersions.put(MetadataVersion.FEATURE_NAME,
metadataVersion.featureLevel());
+ featureVersions.put(KRaftVersion.FEATURE_NAME,
raftClient.kraftVersion().featureLevel());
+ bootstrapMetadata =
BootstrapMetadata.fromVersions(metadataVersion, featureVersions, "generated
default");
Review Comment:
If we're not reading the 0-0.checkpoint, `bootstrapMetadata` is either:
1. read from `bootstrap.checkpoint` and passed down here, so it is non-null.
2. null, because it should have already been written to the log as part of
the 0-0.checkpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
