smjn commented on code in PR #20826:
URL: https://github.com/apache/kafka/pull/20826#discussion_r2493799885


##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -6582,6 +6583,131 @@ class KafkaApisTest extends Logging {
     assertArrayEquals(expectedAcquiredRecords(10, 19, 1).toArray(), 
topicResponse.partitions.get(0).acquiredRecords.toArray())
   }
 
+  @Test
+  def testHandleShareFetchRequestSuccessWithRenewAcknowledgements(): Unit = {

Review Comment:
   It will not make much difference as we are mocking the meat of the method - 
`sharePartitionManager.fetchMessages`. Will add nevertheless.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to