adixitconfluent commented on code in PR #20826:
URL: https://github.com/apache/kafka/pull/20826#discussion_r2493981791
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -6708,6 +6709,76 @@ class KafkaApisTest extends Logging {
verify(sharePartitionManager, times(1)).fetchMessages(any(), any(), any(),
anyInt(), anyInt(), anyInt(), any())
}
+ @ParameterizedTest
+ @CsvSource(value=Array("true,false", "false,true"))
+ def testHandleShareAcknowledgeRequestWithRenewAcknowledgements(isRenewAck:
Boolean, shouldFail: Boolean): Unit = {
+ val topicName = "foo"
+ val topicId = Uuid.randomUuid()
+ val partitionIndex = 0
+ metadataCache = initializeMetadataCacheWithShareGroupsEnabled()
+ addTopicToMetadataCache(topicName, 1, topicId = topicId)
+ val memberId: Uuid = Uuid.randomUuid()
+
+ val groupId = "group"
+
+ when(clientQuotaManager.maybeRecordAndGetThrottleTimeMs(
Review Comment:
We don't need this mock. We should get rid of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
