mjsax commented on code in PR #20693:
URL: https://github.com/apache/kafka/pull/20693#discussion_r2496661085
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java:
##########
@@ -93,9 +93,10 @@ class PartitionGroup extends AbstractPartitionGroup {
}
@Override
- boolean readyToProcess(final long wallClockTime) {
+ ReadyToProcessResult readyToProcess(final long wallClockTime) {
+ Optional<String> logMessage = Optional.empty();
if (maxTaskIdleMs == StreamsConfig.MAX_TASK_IDLE_MS_DISABLED) {
- if (logger.isTraceEnabled() && !allBuffered && totalBuffered > 0) {
+ if (!allBuffered && totalBuffered > 0) {
Review Comment:
I believe we would want to keep this unchanged, and just return `new
ReadyToProcessResult(true, Optional.empty());`
The existing trace log is for the case when we are processable, and the idea
of `ReadyToProcessResult` is return a log message only for the "not
processable" case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
