mjsax commented on code in PR #20693:
URL: https://github.com/apache/kafka/pull/20693#discussion_r2496676266
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractPartitionGroup.java:
##########
@@ -25,7 +25,29 @@
abstract class AbstractPartitionGroup {
- abstract boolean readyToProcess(long wallClockTime);
+ /**
+ * Result of readyToProcess check, containing both the readiness status
+ * and an optional diagnostic log message.
+ */
+ static final class ReadyToProcessResult {
+ private final boolean ready;
+ private final Optional<String> logMessage;
+
+ ReadyToProcessResult(final boolean ready, final Optional<String>
logMessage) {
+ this.ready = ready;
+ this.logMessage = logMessage;
Review Comment:
Should we add a check, if `ready == true`, `logMessage` cannot be empty, and
if `ready == true`, `logMessage` should be empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
