chirag-wadhwa5 commented on code in PR #20839:
URL: https://github.com/apache/kafka/pull/20839#discussion_r2502458586
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -620,6 +624,22 @@ class BrokerServer(
}
}
+ private def createPartitionMetadataClient(): PartitionMetadataClient = {
+ new PartitionMetadataClient {
+ override def listLatestOffsets(topicPartitions: util.Set[TopicPartition]
+ ): util.Map[TopicPartition,
util.concurrent.CompletableFuture[java.lang.Long]] = {
+ topicPartitions.asScala
+ .map { tp =>
+ tp ->
CompletableFuture.completedFuture(java.lang.Long.valueOf(-1L))
+ }
+ .toMap
+ .asJava
Review Comment:
Thanks for the review. Actually, this is a placeholder. I am working in
parallel on a separate PR that will create an implementation class of
`PartitionMetadataClient` using the `InterBrokerSendThread` to fetch the
partition end offsets. Once that PR is completed, I can simply plug in the
instance of the new impl class here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
