apoorvmittal10 commented on code in PR #20839:
URL: https://github.com/apache/kafka/pull/20839#discussion_r2502599728
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -620,6 +624,22 @@ class BrokerServer(
}
}
+ private def createPartitionMetadataClient(): PartitionMetadataClient = {
+ new PartitionMetadataClient {
+ override def listLatestOffsets(topicPartitions: util.Set[TopicPartition]
+ ): util.Map[TopicPartition,
util.concurrent.CompletableFuture[java.lang.Long]] = {
+ topicPartitions.asScala
+ .map { tp =>
+ tp ->
CompletableFuture.completedFuture(java.lang.Long.valueOf(-1L))
+ }
+ .toMap
+ .asJava
Review Comment:
Makes sense, but it should be written as comment in BrokerServer.scala and
in PR description. Can you please do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
