apoorvmittal10 commented on code in PR #20852: URL: https://github.com/apache/kafka/pull/20852#discussion_r2511647883
########## core/src/main/java/kafka/server/NetworkPartitionMetadataClient.java: ########## @@ -0,0 +1,311 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package kafka.server; + +import org.apache.kafka.clients.ClientResponse; +import org.apache.kafka.clients.CommonClientConfigs; +import org.apache.kafka.clients.KafkaClient; +import org.apache.kafka.common.IsolationLevel; +import org.apache.kafka.common.Node; +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.message.ListOffsetsRequestData.ListOffsetsPartition; +import org.apache.kafka.common.message.ListOffsetsRequestData.ListOffsetsTopic; +import org.apache.kafka.common.message.ListOffsetsResponseData.ListOffsetsPartitionResponse; +import org.apache.kafka.common.message.ListOffsetsResponseData.ListOffsetsTopicResponse; +import org.apache.kafka.common.network.ListenerName; +import org.apache.kafka.common.protocol.Errors; +import org.apache.kafka.common.requests.ListOffsetsRequest; +import org.apache.kafka.common.requests.ListOffsetsResponse; +import org.apache.kafka.common.utils.Time; +import org.apache.kafka.coordinator.group.metrics.PartitionMetadataClient; +import org.apache.kafka.metadata.MetadataCache; +import org.apache.kafka.server.util.InterBrokerSendThread; +import org.apache.kafka.server.util.RequestAndCompletionHandler; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentLinkedQueue; +import java.util.stream.Collectors; + +public class NetworkPartitionMetadataClient implements PartitionMetadataClient { + + private static final Logger log = LoggerFactory.getLogger(NetworkPartitionMetadataClient.class); + + private final MetadataCache metadataCache; + private final SendThread sendThread; + private final Time time; + private final ListenerName listenerName; + + public NetworkPartitionMetadataClient( + MetadataCache metadataCache, + KafkaClient networkClient, + Time time, + ListenerName listenerName + ) { + this.metadataCache = metadataCache; + this.time = time; + this.listenerName = listenerName; + this.sendThread = new SendThread( + "NetworkPartitionMetadataClientSendThread", + networkClient, + Math.toIntExact(CommonClientConfigs.DEFAULT_SOCKET_CONNECTION_SETUP_TIMEOUT_MAX_MS), //30 seconds + this.time + ); + this.sendThread.start(); + } + + @Override + public Map<TopicPartition, CompletableFuture<ListOffsetsPartitionResponse>> listLatestOffsets( + Set<TopicPartition> topicPartitions + ) { + if (topicPartitions == null || topicPartitions.isEmpty()) { + return new HashMap<>(); Review Comment: ```suggestion return Map.of(); ``` ########## core/src/main/java/kafka/server/NetworkPartitionMetadataClient.java: ########## @@ -0,0 +1,311 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package kafka.server; + +import org.apache.kafka.clients.ClientResponse; +import org.apache.kafka.clients.CommonClientConfigs; +import org.apache.kafka.clients.KafkaClient; +import org.apache.kafka.common.IsolationLevel; +import org.apache.kafka.common.Node; +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.message.ListOffsetsRequestData.ListOffsetsPartition; +import org.apache.kafka.common.message.ListOffsetsRequestData.ListOffsetsTopic; +import org.apache.kafka.common.message.ListOffsetsResponseData.ListOffsetsPartitionResponse; +import org.apache.kafka.common.message.ListOffsetsResponseData.ListOffsetsTopicResponse; +import org.apache.kafka.common.network.ListenerName; +import org.apache.kafka.common.protocol.Errors; +import org.apache.kafka.common.requests.ListOffsetsRequest; +import org.apache.kafka.common.requests.ListOffsetsResponse; +import org.apache.kafka.common.utils.Time; +import org.apache.kafka.coordinator.group.metrics.PartitionMetadataClient; +import org.apache.kafka.metadata.MetadataCache; +import org.apache.kafka.server.util.InterBrokerSendThread; +import org.apache.kafka.server.util.RequestAndCompletionHandler; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentLinkedQueue; +import java.util.stream.Collectors; + +public class NetworkPartitionMetadataClient implements PartitionMetadataClient { + + private static final Logger log = LoggerFactory.getLogger(NetworkPartitionMetadataClient.class); + + private final MetadataCache metadataCache; + private final SendThread sendThread; + private final Time time; + private final ListenerName listenerName; + + public NetworkPartitionMetadataClient( + MetadataCache metadataCache, + KafkaClient networkClient, + Time time, + ListenerName listenerName + ) { + this.metadataCache = metadataCache; + this.time = time; + this.listenerName = listenerName; + this.sendThread = new SendThread( + "NetworkPartitionMetadataClientSendThread", + networkClient, + Math.toIntExact(CommonClientConfigs.DEFAULT_SOCKET_CONNECTION_SETUP_TIMEOUT_MAX_MS), //30 seconds + this.time + ); + this.sendThread.start(); Review Comment: Are we going to crerate a new NetworkClient with new connection to every broker or re-use some existing network client? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
