apoorvmittal10 commented on code in PR #20852: URL: https://github.com/apache/kafka/pull/20852#discussion_r2527067564
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ########## Review Comment: Better handling would be to check if `error` is not null, if that's the case then log and throw exception. As the API for listOffsets is not expected to complete and future exceptionally now. ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ########## Review Comment: If it's not required then remove it, I am not sure why defence and try-catch is needed, if the future should never be completed exceptionally. ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ########## Review Comment: Better handling would be to check if `error` is not null, if that's the case then log and throw exception. As the API for listOffsets is not expected to complete the future exceptionally now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
