kirktrue commented on PR #20792: URL: https://github.com/apache/kafka/pull/20792#issuecomment-3544529617
@LiamClarkeNZ—thanks for the review! > Only feedback is that it might be good to have a unit test at the `AsyncKafkaConsumerTest` level along the lines of one for `KafkaConsumerTest`? But this isn't blocking feedback. The `AsyncKafkaConsumer` is used under the hood in the `KafkaConsumerTest.testConstructorFailsOnNetworkClientConstructorFailure()`. when the `GroupProtocol` equals `CONSUMER`, under the covers `KafkaConsumer` will create an `AsyncKafkaConsumer`. I'm not sure what form a unit test in `AsyncKafkaConsumerTest` would look like, unless I'm misunderstanding your suggestion 🤔 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
