kirktrue commented on PR #20792: URL: https://github.com/apache/kafka/pull/20792#issuecomment-3544538805
Thanks for the review @AndrewJSchofield! > Please can you implement a test in `ShareConsumerImplTest` which mirrors the test you provided for `KafkaConsumerTest`. This affects the share consumer and we don't really have any test for that. I added `testConstructorFailsOnNetworkClientConstructorFailure()` to `ShareConsumerImplTest` with minimal changes from `KafkaConsumerTest`’s version. PTAL. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
