apoorvmittal10 commented on code in PR #21001:
URL: https://github.com/apache/kafka/pull/21001#discussion_r2571029010
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -635,7 +635,8 @@ class BrokerServer(
new LogContext(s"[NetworkPartitionMetadataClient
broker=${config.brokerId}]")
),
Time.SYSTEM,
- config.interBrokerListenerName()
+ config.interBrokerListenerName(),
+ new SystemTimerReaper("network-partition-metadata-client-reaper", new
SystemTimer("network-partition-metadata-client"))
Review Comment:
Personally I think we are using far more complicated thing, SystemTimer, for
smaller retry mechanism. AdminApiDriver also uses exponential back off without
SystemTimer. Can we see if we could implement similarly?
##########
clients/src/main/java/org/apache/kafka/common/utils/ExponentialBackoffManager.java:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kafka.common.utils;
+
+import org.apache.kafka.clients.CommonClientConfigs;
+
+/**
+ * Manages retry attempts and exponential backoff for requests.
+ */
+public class ExponentialBackoffManager {
Review Comment:
There already exists
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/utils/ExponentialBackoff.java,
can't that be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
