chia7712 commented on code in PR #21008:
URL: https://github.com/apache/kafka/pull/21008#discussion_r2576173586
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -2354,16 +2357,18 @@ public void onResignation(
}
/**
- * See {@link
GroupCoordinator#onNewMetadataImage(CoordinatorMetadataImage,
CoordinatorMetadataDelta)}.
+ * See {@link GroupCoordinator#onMetadataUpdate(MetadataDelta,
MetadataImage)}.
*/
@Override
- public void onNewMetadataImage(
- CoordinatorMetadataImage newImage,
- CoordinatorMetadataDelta delta
+ public void onMetadataUpdate(
+ MetadataDelta delta,
+ MetadataImage newImage
) {
throwIfNotActive();
- metadataImage = newImage;
- runtime.onNewMetadataImage(newImage, delta);
+ var wrappedImage = newImage == null ? null : new
KRaftCoordinatorMetadataImage(newImage);
Review Comment:
Can the image be `null`? Since a `null` `wrappedImage` causes an NPE in
`CoordinatorRuntime#onMetadataUpdate`, if `null` input is allowed, we should
implement a fast-fail
https://github.com/apache/kafka/blob/ed3af7212405dd5294733ad33d192f12dc885fc2/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java#L2546
##########
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java:
##########
@@ -2535,12 +2535,12 @@ public void scheduleUnloadOperation(
/**
* A new metadata image is available.
*
- * @param newImage The new metadata image.
- * @param delta The metadata delta.
+ * @param delta The metadata delta.
+ * @param newImage The new metadata image.
*/
- public void onNewMetadataImage(
- CoordinatorMetadataImage newImage,
- CoordinatorMetadataDelta delta
+ public void onMetadataUpdate(
+ CoordinatorMetadataDelta delta,
Review Comment:
Should the `ShareCoordinator` also be updated with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
