shashankhs11 commented on code in PR #21059:
URL: https://github.com/apache/kafka/pull/21059#discussion_r2587044973


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -646,29 +632,24 @@ private static DefaultTaskManager 
maybeCreateSchedulingTaskManager(final boolean
         return null;
     }
 
-    private static StateUpdater maybeCreateStateUpdater(final boolean 
stateUpdaterEnabled,
-                                                                final 
StreamsMetricsImpl streamsMetrics,
-                                                                final 
StreamsConfig streamsConfig,
-                                                                final 
Consumer<byte[], byte[]> restoreConsumer,
-                                                                final 
ChangelogReader changelogReader,
-                                                                final 
TopologyMetadata topologyMetadata,
-                                                                final Time 
time,
-                                                                final String 
clientId,
-                                                                final int 
threadIdx) {
-        if (stateUpdaterEnabled) {
-            final String name = clientId + STATE_UPDATER_ID_SUBSTRING + 
threadIdx;
-            return new DefaultStateUpdater(
-                name,
-                streamsMetrics,
-                streamsConfig,
-                restoreConsumer,
-                changelogReader,
-                topologyMetadata,
-                time
-            );
-        } else {
-            return null;
-        }
+    private static StateUpdater maybeCreateStateUpdater(final 
StreamsMetricsImpl streamsMetrics,

Review Comment:
   addressed in 6cff200



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to