lucasbru commented on code in PR #21059:
URL: https://github.com/apache/kafka/pull/21059#discussion_r2590147117
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1066,13 +1023,6 @@ void maybeGetClientInstanceIds() {
);
}
}
-
- if (mainConsumerInstanceIdFuture.isDone()
Review Comment:
But suppose you replace !stateUpdaterEnabled with false (so state updater
enabled), then this condition will always be false, and we never reset the
fetchDeadline. So I think the condition didn't do what was intended. But I
agree that we probably shoudn't remove the whole block if this logic you
describe was intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
