ahuang98 commented on code in PR #21114:
URL: https://github.com/apache/kafka/pull/21114#discussion_r2604700247
##########
metadata/src/test/java/org/apache/kafka/controller/PartitionReassignmentReplicasTest.java:
##########
@@ -197,12 +197,80 @@ public void testIsReassignmentInProgress() {
}
@Test
- public void
testDoesNotCompleteReassignmentIfIsrDoesNotHaveAllTargetReplicas() {
+ public void
testCompleteReassignmentIfIsrDoesNotHaveAnExistingTargetReplica() {
Review Comment:
nit on name: `testCanCompleteReassignment....`
##########
metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java:
##########
@@ -119,7 +119,10 @@ Optional<CompletedReassignment>
maybeCompleteReassignment(List<Integer> targetIs
}
if (newTargetReplicas.isEmpty()) return Optional.empty();
}
- if (!newTargetIsr.containsAll(newTargetReplicas)) return
Optional.empty();
+
Review Comment:
let's add some comments for L123 and L125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
