ahuang98 commented on code in PR #21114:
URL: https://github.com/apache/kafka/pull/21114#discussion_r2611787362
##########
metadata/src/test/java/org/apache/kafka/controller/PartitionReassignmentReplicasTest.java:
##########
@@ -197,12 +197,80 @@ public void testIsReassignmentInProgress() {
}
@Test
- public void
testDoesNotCompleteReassignmentIfIsrDoesNotHaveAllTargetReplicas() {
+ public void
testCanCompleteReassignmentIfIsrDoesNotHaveAnExistingTargetReplica() {
Review Comment:
should we test when replica 0 is missing as well? when both replica 0 and
replica 1 are missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
