jolshan commented on code in PR #21096:
URL: https://github.com/apache/kafka/pull/21096#discussion_r2628647232
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateEntry.java:
##########
@@ -55,11 +55,11 @@ public ProducerStateEntry(long producerId, short
producerEpoch, int coordinatorE
firstBatchMetadata.ifPresent(batchMetadata::add);
Review Comment:
In the code, it looks like we tend to use the same value in the
batchMetadata timestamp as the we do when creating the state (or the -1 value
if no batchMetadata)
I think in some cases we don't have the batchMetadata, and we use a
different method to update it there anyway. This code is pretty complicated, so
maybe I'm missing something, but just want to make sure we aren't making it
more complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
